chore: Simplify the workspaces list #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incidentally unbreaks `deno install`.
|
The change looks fine but the Eclipse ECA check fails... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1327 +/- ##
==========================================
- Coverage 77.46% 76.51% -0.96%
==========================================
Files 83 83
Lines 16576 16576
Branches 1667 1620 -47
==========================================
- Hits 12841 12683 -158
- Misses 3678 3837 +159
+ Partials 57 56 -1 ☔ View full report in Codecov by Sentry. |
|
@lu-zero can you look into the ECA check failure... If it is too cumbersome, and you don't mind, someone on our side could provide a similar PR... |
|
It should be fine now, sorry for the delay. |
relu91
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incidentally unbreaks
deno install.